Skip to content

Conversation

@willdavitt
Copy link
Contributor

Before this PR

After this PR

==COMMIT_MSG==
Add refreshing oauth token
==COMMIT_MSG==

Possible downsides?

Are Docs needed?

Will Davitt added 2 commits March 13, 2025 13:13
@changelog-app
Copy link

changelog-app bot commented Mar 13, 2025

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Add refreshing oauth token

Check the box to generate changelog(s)

  • Generate changelog entry

Comment on lines +60 to +63


class RefreshingOauthToken:
def __init__(self, hostname: str, scope: List[str], refresh_interval: int = 1800) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but please lets add docs on the README for this

lauraAriasFdez
lauraAriasFdez previously approved these changes Mar 13, 2025
@policy-bot policy-bot bot dismissed lauraAriasFdez’s stale review March 13, 2025 23:31

Invalidated by push of af3201e

@willdavitt willdavitt merged commit e47b796 into develop Mar 18, 2025
11 checks passed
@scottkruyswyk scottkruyswyk deleted the wdavitt/refreshingOauth branch April 3, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants