Fix author value for bot-authored pull requests #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v3 API includes the '[bot]' suffix, while the v4 API does not. Depending on how the context was created, the object may have come from either API, so we need the helper function to standardize the value.
asvoboda
approved these changes
Sep 9, 2020
|
thanks ! |
bluekeyes
added a commit
that referenced
this pull request
Sep 11, 2020
The v3 API includes the '[bot]' suffix, while the v4 API does not. Depending on how the context was created, the object may have come from either API, so we need the helper function to standardize the value. (cherry picked from commit 5b3a180)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v3 API includes the '[bot]' suffix, while the v4 API does not. Depending on how the context was created, the object may have come from either API, so we need the helper function to standardize the value.
This might fix the bug in #230, but we'd have to backport to a 1.17.x release branch to test it out.