Use slug-based APIs for team operations #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the total number of requests by eliminating calls to enumerate all teams, which were previously required to discover all team IDs and map them to names. These APIs are only available on GitHub.com and in GitHub Enterprise 2.21 or newer, so policy-bot is no longer compatible with older versions of GitHub Enterprise.
asvoboda
approved these changes
Jul 31, 2020
|
Since this will cut off the number of GHE versions we support pretty dramatically, I intend to release it as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the total number of requests by eliminating calls to enumerate all teams, which were previously required to discover all team IDs and map them to names.
These APIs are only available on GitHub.com and in GitHub Enterprise 2.21 or newer, so policy-bot is no longer compatible with older versions of GitHub Enterprise.
I still need to fix up the tests and check to see if there are any other optimizations we should make to team operations.
Fixes #200.