nit: add comment to explain dismissed case

palantir · Oct 23, 2024 · 3f3be64 · 3f3be64
1 parent 96cae87
commit 3f3be64
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/server/handler/pull_request_review.go b/server/handler/pull_request_review.go
@@ -88,7 +88,8 @@ func (h *PullRequestReview) Handle(ctx context.Context, eventType, deliveryID st
 
 func (h *PullRequestReview) affectsApproval(reviewState pull.ReviewState, config *policy.Config) bool {
 	states := make(map[pull.ReviewState]struct{})
-	// Include dismissed state
+
+	// Always process events for dismissed reviews because they can revert the overall approval or disapproval to a previous state
 	states[pull.ReviewDismissed] = struct{}{}
 
 	for _, rule := range config.ApprovalRules {