-
Notifications
You must be signed in to change notification settings - Fork 17
Excavator: Switch to JUnit 5 to parallelize tests and speed up CI #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cb78578
to
98687c0
Compare
98687c0
to
560495e
Compare
560495e
to
39294ca
Compare
39294ca
to
64decf2
Compare
c20776f
to
9e73c22
Compare
9e73c22
to
e9b5810
Compare
e9b5810
to
d846805
Compare
d846805
to
9e0ddb6
Compare
9e0ddb6
to
f94e3bc
Compare
f94e3bc
to
440999a
Compare
440999a
to
5e6b42f
Compare
5e6b42f
to
f100d76
Compare
f100d76
to
07eda51
Compare
07eda51
to
11ee87e
Compare
11ee87e
to
3eef55d
Compare
3eef55d
to
02431c2
Compare
02431c2
to
f4328e2
Compare
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
f4328e2
to
bcd1b03
Compare
bcd1b03
to
90ac530
Compare
90ac530
to
2bdb26a
Compare
As discussed internally, There were three options:
Compiler.javac()
.withProcessors(new AbstractProcessor() {
@Override
public boolean process(Set<? extends TypeElement> annotations, RoundEnvironment roundEnv) {
test.accept(processingEnv.getElementUtils());
return false;
}
})
.compile(DUMMY)
We decided to go with that third option for now and disable the excavator once this PR merges |
Assertions.assertThrows(NullPointerException.class, () -> { | ||
TypeName.BOOLEAN.annotated((AnnotationSpec[]) null); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use AssertJ
Assertions.assertThrows(NullPointerException.class, () -> { | |
TypeName.BOOLEAN.annotated((AnnotationSpec[]) null); | |
}); | |
assertThatThrownBy(() -> { | |
TypeName.BOOLEAN.annotated((AnnotationSpec[]) null); | |
}) | |
.isInstanceOf(NullPointerException.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed - this was updated by the excacvator and I didn't notice. I'll push a change
excavator is a bot for automating changes across repositories.
Changes produced by the roomba/junit5 check.
To enable or disable this check, please contact the maintainers of Excavator.