add ability to configure Timeout for http.Client - #48
Merged
Conversation
bluekeyes
approved these changes
Jul 15, 2020
bluekeyes
left a comment
bluekeyes
left a comment
Contributor
There was a problem hiding this comment.
Minor suggestion on the doc comment, but looks good otherwise.
| } | ||
|
|
||
| // WithClientTimeout sets the timeout on http.Client for all created clients. This will set a timeout | ||
| // on all requests made by the client. |
Contributor
There was a problem hiding this comment.
style: WithClientTimeout sets a request timeout for requests made by all created clients.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to configure the
http.Client's Timeout field, which is used to set a timeout for requests made by the client.