Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add markdown sourcePath property #69

Merged
merged 4 commits into from
Jun 19, 2018
Merged

add markdown sourcePath property #69

merged 4 commits into from
Jun 19, 2018

Conversation

giladgray
Copy link
Contributor

path to markdown file. this is necessary for supporting "edit" links like palantir/blueprint#101

@giladgray giladgray requested a review from themadcreator June 19, 2018 19:22
@blueprint-bot
Copy link

📸

Preview: docs

@@ -30,6 +30,9 @@ export interface IMarkdownPluginData {
* A single Documentalist page, parsed from a single source file.
*/
export interface IPageData extends IBlock {
/** Relative path to the original source file. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirm if this is always actually relative.

@blueprint-bot
Copy link

relative path

Preview: docs

@blueprint-bot
Copy link

filePath => sourcePath

Preview: docs

@blueprint-bot
Copy link

filePath => sourcePath

Preview: docs

@giladgray giladgray merged commit 00bb426 into master Jun 19, 2018
@giladgray giladgray deleted the gg/md-filepath branch June 19, 2018 21:44
@giladgray giladgray changed the title add markdown filePath property add markdown sourcePath property Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants