Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constructor type info #49

Merged
merged 11 commits into from
Dec 25, 2017
Merged

constructor type info #49

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
57a5c1d
add constructorType and implements keys
Dec 24, 2017
bd2bec5
resolve constructor signature like a function
Dec 24, 2017
79cebcb
include type args in ReferenceType
Dec 24, 2017
0c3b7c9
add constructor & implements to template, cooler header
Dec 24, 2017
315195f
handle {} type
Dec 24, 2017
6149b63
dddupdate snapsiihots
Dec 24, 2017
149b0ab
"," word separator
Dec 24, 2017
94a57ad
defaultValue becomes ? in signature
Dec 24, 2017
e5ae2ac
Merge branch 'master' of github.com:palantir/documentalist into gg/co…
Dec 24, 2017
b94e337
add constructor Kind, sort static props/methods first
Dec 25, 2017
89ba77c
📸
Dec 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
defaultValue becomes ? in signature
  • Loading branch information
Gilad Gray committed Dec 24, 2017
commit 94a57ada81b74fe6f3d9f25c22d4550d10fb0748
2 changes: 1 addition & 1 deletion src/plugins/typescript/typestring.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export function resolveSignature(sig: SignatureReflection): string {
[
param.flags.isRest ? "..." : "",
param.name,
param.flags.isOptional ? "?" : "",
param.flags.isOptional || param.defaultValue ? "?" : "",
": ",
resolveTypeString(param.type),
].join(""),
Expand Down