MarkdownPlugin populates route property
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 17, 2017 11:19
does not nest references, also depths aren't 100% accurate yet.
works really well, does not rewrite references.
to make rendering headings really easy. Compiler turns all `@#+` tags into `tag: "heading"`, but can't populate `route` yet. Page operates on "page" and "heading" tags (so readable!).
with fully qualified path to the resource: `path/to/page[.heading]`. remove obsolete heading/pageReference options as all slugification happens inside MarkdownPlugin.
themadcreator
approved these changes
Mar 21, 2017
| * Type guard to determine if a `contents` node is an `@tag` statement. | ||
| * Optionally tests tag name too, if `tagName` arg is provided. | ||
| */ | ||
| export function isTag(node: StringOrTag, tagName?: string): node is ITag { |
There was a problem hiding this comment.
yep very proud of this
add fake _nav page in markdown testPreview: docs |
minor polishPreview: docs |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IHeadingTag extends ITagwith route & level to make rendering headings really easy.@#+tags intotag: "heading", but can't populaterouteyet.routeproperty in pages and nav with fully qualified path to the resource:path/to/page[.heading].