Skip to content

add ability to observe deadline expiration counts #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bjlaub
Copy link
Contributor

@bjlaub bjlaub commented Apr 24, 2025

Provides the ability to observe the number of deadline expirations that happen between two points in time. Intended for consumers to be able to potentially build more customized observability outside of the metrics reported directly by this library.

A ExpirationObservation just reads the value of the internal meters between two points in time and exposes a count of the number of expirations that occurred.

Alternative to #92

Provides the ability to observe the number of deadline expirations that
happen between two points in time. Intended for consumers to be able
to potentially build more customized observability outside of the
metrics reported directly by this library.

A `ExpirationObservation` just reads the value of the internal meters
between two points in time and exposes a count of the number of
expirations that occurred.
@changelog-app
Copy link

changelog-app bot commented Apr 24, 2025

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

add ability to observe deadline expiration counts

Check the box to generate changelog(s)

  • Generate changelog entry

@bjlaub bjlaub marked this pull request as ready for review April 24, 2025 18:52
@bjlaub bjlaub requested a review from mpritham April 24, 2025 18:53
}

@VisibleForTesting
long totalWithPropagateIntent() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could make this (or all of these) public to allow consumers to e.g. observe when a deadline expiration would throw an exception if enforcement is enabled.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are your thoughts on something like #95? I think it's a bit simpler: I'm proposing we just expose the deadline metric values and provide a small utility to compute diffs between the metric value observations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants