allow negative deadlines returned by getRemainingDeadline #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we always returned Duration.ZERO if the deadline had expired. This is straightforward and keeps some detail hidden from consumers, at the expense of some flexibility.
With this change, just return the raw remaining deadline value as a Duration, which may be less than zero. This allows consumers the flexibility to report observability metrics on deadline expiration (for instance, they can know how far past a deadline some call chain has gone which may be of interest in debugging).