Skip to content

allow negative deadlines returned by getRemainingDeadline #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bjlaub
Copy link
Contributor

@bjlaub bjlaub commented Apr 11, 2025

Previously we always returned Duration.ZERO if the deadline had expired. This is straightforward and keeps some detail hidden from consumers, at the expense of some flexibility.

With this change, just return the raw remaining deadline value as a Duration, which may be less than zero. This allows consumers the flexibility to report observability metrics on deadline expiration (for instance, they can know how far past a deadline some call chain has gone which may be of interest in debugging).

Previously we always returned Duration.ZERO if the deadline had expired.
This is straightforward and keeps some detail hidden from consumers, at
the expense of some flexibility.

With this change, just return the raw remaining deadline value as a
Duration, which may be less than zero. This allows consumers the
flexibility to report observability metrics on deadline expiration (for
instance, they can know how far past a deadline some call chain has gone
which may be of interest in debugging).
@changelog-app
Copy link

changelog-app bot commented Apr 11, 2025

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

allow negative deadlines returned by getRemainingDeadline

Check the box to generate changelog(s)

  • Generate changelog entry

@bjlaub
Copy link
Contributor Author

bjlaub commented May 8, 2025

this could be replaced by #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant