Add brandedAliases option for strongly branded aliases #225
Conversation
Generate changelog in
|
|
|
||
| const irDir = path.join(__dirname, "../../../../build/ir-test-cases"); | ||
| const testCaseDir = path.join(__dirname, "resources/test-cases"); | ||
| const brandedTestCaseDir = path.join(__dirname, "resources/branded-test-cases"); |
There was a problem hiding this comment.
I was torn on duplicating the test-cases again and having a whole other copy of these generated files for this generatorTest, but I think it's good to be clear and actually differentiate the flavored from branded.
It does make for some noise now in this PR though, at least you can skip over anything src/commands/generate/__tests__/resources/branded-test-cases/** (they're also the only added files)
| `\t${FLAVOR_TYPE_FIELD}?: "${definition.typeName.name}",`, | ||
| `\t${FLAVOR_PACKAGE_FIELD}?: "${definition.typeName.package}",`, | ||
| `\t${FLAVOR_TYPE_FIELD}${maybeOptional}: "${definition.typeName.name}",`, | ||
| `\t${FLAVOR_PACKAGE_FIELD}${maybeOptional}: "${definition.typeName.package}",`, |
There was a problem hiding this comment.
This is the only actual generator change
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
Before this PR
Flavored aliases are great but don't quite afford enough type safety in projects that require stricter typing to avoid accidental misuse, at the cost of requiring more intentional type assertions.
Hopefully the readme additions describe/justify the difference and tradeoff between flavorizing & branded.
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?