Restore joda deserialization #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
reviewed
Dec 7, 2020
| @@ -65,6 +66,7 @@ jakarta.el:jakarta.el-api:3.0.3 (1 constraints: fe135465) | |||
| jakarta.validation:jakarta.validation-api:2.0.2 (3 constraints: 8e372576) | |||
| jakarta.ws.rs:jakarta.ws.rs-api:2.1.6 (12 constraints: 4cd52d0a) | |||
| jakarta.xml.bind:jakarta.xml.bind-api:2.3.2 (1 constraints: 30198ba6) | |||
| joda-time:joda-time:2.10.8 (2 constraints: b4238380) | |||
There was a problem hiding this comment.
not a huge fan of including joda in cjr, but I don't want to regress folks
There was a problem hiding this comment.
agreed - if we were being more brutal I think we should just wait for the P0s and then ask people to manually add the dep, but I think this would be too mean :/
carterkozak
approved these changes
Dec 7, 2020
|
Released 6.9.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
@rahij reported in #dev-foundry-infra (/archives/C5MKHTMD4/p1607350000042200) that after the jackson 2.12.0 upgrade, deserializing some classes from our
<analysis product>which previously worked with a vanilla c-j-r object mapper started failing with:After this PR
==COMMIT_MSG==
conjure-java-jackson-serialization: joda types can once again be deserialized (as this was a behaviour change of the jackson 2.12 upgrade)
==COMMIT_MSG==
https://github.com/FasterXML/jackson-databind/blob/39fab67429c0f23399f031e0c0dbd4a13a73622d/release-notes/VERSION-2.x#L71-L72
FasterXML/jackson-databind#2776
Possible downsides?