Skip to content

Excavator: Remove calls to deprecated APIs #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+0 −6
Open

Excavator: Remove calls to deprecated APIs #1483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion errors/src/test/java/com/palantir/conjure/java/api/errors/RemoteExceptionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@

public final class RemoteExceptionTest {

@SuppressWarnings("for-rollout:deprecation")
@Test
public void testJavaSerialization() {
// With explicit error instance
Expand Down
1 change: 0 additions & 1 deletion ...ackson-support/src/main/java/com/palantir/conjure/java/api/ext/jackson/ObjectMappers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ public static ObjectMapper newCborServerObjectMapper() {
* <li>Deserializing a null for a primitive field will throw an exception.
* </ul>
*/
@SuppressWarnings("for-rollout:deprecation")
public static ObjectMapper withDefaultModules(ObjectMapper mapper) {
return mapper.registerModule(new GuavaModule())
.registerModule(new ShimJdk7Module())
Expand Down
4 changes: 0 additions & 4 deletions test-utils/src/main/java/com/palantir/conjure/java/api/testing/Assertions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import org.assertj.core.util.CanIgnoreReturnValue;
import org.assertj.core.util.CheckReturnValue;

@SuppressWarnings("for-rollout:deprecation")
@CheckReturnValue
public class Assertions extends org.assertj.core.api.Assertions {

Expand All @@ -41,19 +40,16 @@ public static QosExceptionAssert assertThat(QosException actual) {
return new QosExceptionAssert(actual);
}

@SuppressWarnings("for-rollout:deprecation")
@CanIgnoreReturnValue
public static ServiceExceptionAssert assertThatServiceExceptionThrownBy(ThrowingCallable shouldRaiseThrowable) {
return assertThatThrownBy(shouldRaiseThrowable).asInstanceOf(ServiceExceptionAssert.instanceOfAssertFactory());
}

@SuppressWarnings("for-rollout:deprecation")
@CanIgnoreReturnValue
public static RemoteExceptionAssert assertThatRemoteExceptionThrownBy(ThrowingCallable shouldRaiseThrowable) {
return assertThatThrownBy(shouldRaiseThrowable).asInstanceOf(RemoteExceptionAssert.instanceOfAssertFactory());
}

@SuppressWarnings("for-rollout:deprecation")
@CanIgnoreReturnValue
public static QosExceptionAssert assertThatQosExceptionThrownBy(ThrowingCallable shouldRaiseThrowable) {
return assertThatThrownBy(shouldRaiseThrowable).asInstanceOf(QosExceptionAssert.instanceOfAssertFactory());
Expand Down