-
Notifications
You must be signed in to change notification settings - Fork 6
Make ptimports work on Windows #59
base: master
Are you sure you want to change the base?
Conversation
b9b4e31
to
f4e8a32
Compare
Thanks for the PR! Most of the core |
No idea! The behavior with backslashes versus slashes was the real problem in ptimports. I just did the CRLF thing to make git stop whining at me about changing line endings. :) |
Looks like yes, goimports also inserts plain newlines:
Never noticed that before because I use VSCode, and apparently it takes care of that already when it runs goimports. |
I submitted a similar PR for goimports to handle the crlf line endings: https://go-review.googlesource.com/c/tools/+/83535 |
5c65c3f
to
f4e8a32
Compare
I've updated the PR to align with the changes they won't make to goimports / gofmt. The rest of the windows fixes are still in place, and it will still treat files as correct if the only difference is line endings. |
There seem to be a few different things going on here. Here's my overview:
Each of these top-level bullet points are independent concerns, so would like to address them in separate PRs/issues as well. Finally, as a heads-up, for the purposes of gödel all of this may be less of a concern, since for 2.0 I'm strongly considering not using |
gödel issue referenced above is at palantir/godel#269. |
Thanks, content looks good! Underlying code has changed since your initial commit and conflicts now exist -- could you update this PR to fix the conflicts? Once that is done, this should be good to merge. |
af56498
to
aac17b2
Compare
Done |
and support files that contain CRLF as their EOL sequence.