[DateRangeInput] Add allowSingleDayRange prop #861
Conversation
| return [startDate, (startDate >= endDate) ? null : endDate] as DateRange; | ||
| const selectedRange = this.props.allowSingleDayRange | ||
| ? [startDate, (clearTime(startDate) > clearTime(endDate)) ? null : endDate] | ||
| : [startDate, (clearTime(startDate) >= clearTime(endDate)) ? null : endDate]; |
There was a problem hiding this comment.
what about DateUtils.areSameDay? that's what DateRangePicker uses to implement this prop.
There was a problem hiding this comment.
wait but actually... why does this get reimplemented here? can we not rely on DRP's own allowSingleDayRange prop implementation?
There was a problem hiding this comment.
Yeah there's a little duplication between the implementation for the next-selected dates on click and the next focused fields on click (and still more duplication/logic overlap for validation).
But you're right: the basic way to check this is !DateUtils.areSameDay(startDate, endDate) && startDate > endDate. Will edit.
|
|
||
| // deselect current end date | ||
| getDayElement(END_DAY).simulate("click"); | ||
|
|
There was a problem hiding this comment.
such whitespace. i mean whatever, but i like keeping blocks of interaction between asserts together.
cmslewis
force-pushed
the
cl/dri-allow-single-day-range
branch
from
055a7a9 to
d869942
Compare
|
@giladgray ready for re-review |
|
|
||
| // this helper function checks if the provided boundary date *would* overlap the selected | ||
| // other boundary date. providing the already-selected start date simply tells us if we're | ||
| // currently in an overlapping state. |
There was a problem hiding this comment.
nits: should the comment go here, or with the method? also, sentence casing
There was a problem hiding this comment.
This is a special usage of the helper function, so I think it makes sense to keep the comment only here.
We don't do sentence casing in comments AFAIK, unless it's a prop-description comment.
Addresses #805
Checklist
Changes proposed in this pull request:
allowSingleDayRangeprop toDateRangeInputReviewers should focus on
Screenshot