Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update syntax highlighting #848

Merged
merged 7 commits into from
Mar 16, 2017
Merged

update syntax highlighting #848

merged 7 commits into from
Mar 16, 2017

Conversation

giladgray
Copy link
Contributor

@giladgray giladgray commented Mar 15, 2017 •
edited
Loading

  • update highlights
  • update language-typescript grammars (latest version is much more sensitive than what we had before, looks a lot more like VSCode)
  • update constants + properties colors to match Blueprint VSCode theme
  • improve light syntax theme readability

this PR is related to and inspired by #846 but is not DM-specific so I'm able to open it here targeting master.

Before

syntax-before-light
syntax-before-dark

After

syntax-after-light
syntax-after-dark

Gilad Gray added 3 commits March 15, 2017 14:38
update highlights + language-typescript
089a2c0
ensure handlebars grammar
5b3aeb5
update syntax theme
f085834 
- improved light theme
- style constants and properties more like VSCode theme
@blueprint-bot
Copy link

update syntax theme

Preview: docs
Coverage: core | datetime

@cmslewis
Copy link
Contributor

@giladgray can you add before/after screenshots?

@blueprint-bot
Copy link

color JSX ={} operator

Preview: docs
Coverage: core | datetime

"support" token (console.log),
7ec1e6e 
highlight constant properties (Intent.PRIMARY)
@giladgray
Copy link
Contributor Author

@cmslewis screenshots added to description

@blueprint-bot
Copy link

"support" token (console.log), highlight constant properties (Intent.PRIMARY)

Preview: docs
Coverage: core | datetime

@giladgray giladgray merged commit 10c1c77 into master Mar 16, 2017
@giladgray giladgray deleted the gg/better-syntax branch March 16, 2017 17:14
@giladgray giladgray mentioned this pull request Mar 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmslewis cmslewis cmslewis approved these changes

Assignees
No one assigned
Labels
Domain: tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giladgray @blueprint-bot @cmslewis