-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[draft] Storybook #7682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ggdouglas
wants to merge
11
commits into
feat/nx-upgrade-17-to-22
Choose a base branch
from
feat/storybook
base: feat/nx-upgrade-17-to-22
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[draft] Storybook #7682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated nx from 17.2.8 to 18.3.5 - Added useInferencePlugins: false to disable Project Crystal - Moved affected.defaultBase to root level defaultBase
- Updated nx from 18.3.5 to 19.8.9 - Updated workspace data directory config
- Updated nx from 19.8.9 to 20.8.3 - Removed deprecated tasksRunnerOptions - Added useLegacyCache: true for migration
- Updated nx from 20.8.3 to 21.6.9 - Removed useLegacyCache (no longer needed) - Updated .gitignore for nx rule files
- Updated nx from 21.6.9 to 22.3.1
NX 22 requires long-running watch tasks to be marked with continuous: true so that NX knows not to wait for them to complete.
Both docs-app and demo-app use port 9001 by default. Running them in parallel causes EADDRINUSE errors.
d01b99a to
1e95bff
Compare
Implement Storybook deployment on CircleCIBuild artifact links for this commit: documentation | landing | table | demo | storybookThis is an automated comment from the deploy-preview CircleCI job. |
Ignore stories in ESLintBuild artifact links for this commit: documentation | landing | table | demo | storybookThis is an automated comment from the deploy-preview CircleCI job. |
6b05cd4 to
c82bbaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Checklist
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot