Optimize site build by removing sourcemaps #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Brought overall site size from 23MB -> 8.4MB |
...instead of preventing them from being emitted in the first place. This allows our default package builds to still have source maps.
|
this addresses #39, though probably not ready to close it yet. |
giladgray
reviewed
Nov 10, 2016
| "copy:docs": "cp -r packages/docs/dist docs/docs", | ||
| "copy:landing": "cp -r packages/landing/dist/* docs/.", | ||
| "build:site": "npm-run-all build:gulp build:landing clean:docs copy:docs copy:landing delete:doc-source-maps", | ||
| "clean:docs": "rm -rf docs && git checkout docs/CNAME", |
There was a problem hiding this comment.
is git checkout docs enough? would handle future tracked files. just thinking aloud here
There was a problem hiding this comment.
I don't think so because then you would never be able to remove things from that folder
greglo
pushed a commit
to greglo/blueprint
that referenced
this pull request
Dec 12, 2016
* Optimize site build by removing sourcemaps * Just strip external sourcemaps from site ...instead of preventing them from being emitted in the first place. This allows our default package builds to still have source maps.
peterblazejewicz
pushed a commit
to peterblazejewicz/blueprint
that referenced
this pull request
Dec 20, 2017
Add class to logo and release 0.2.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.