Handle popover prop on JSONFormat #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, JSONFormat cells would not allow you to change the showPopover prop because it wanted to detect nulls and override the value. Now, if the user actually sets the prop on JSONFormat, we will still hide the popover for nully values, but will use their prop as the default.
giladgray
approved these changes
Jan 12, 2017
| const showPopover = isNully ? TruncatedPopoverMode.NEVER : TruncatedPopoverMode.ALWAYS; | ||
| if (isNully) { | ||
| showPopover = TruncatedPopoverMode.NEVER; | ||
| } |
There was a problem hiding this comment.
pretty sure this is a prefect ternary:
const showPopover = (children == null) ? TruncatedPopoverMode.NEVER : this.props.showPopover;There was a problem hiding this comment.
We re-use isNully to apply a classname later on
There was a problem hiding this comment.
could still use isNully in a ternary, if you care
themadcreator
deleted the
bd/dont-ignore-popover-setting-jsonformatted-cell
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Previously, JSONFormat cells would not allow you to change the
showPopover prop because it wanted to detect nulls and override
the value.
Now, if the user actually sets the prop on JSONFormat, we will
still hide the popover for nully values, but will use their
prop as the default.