applied suggested adjustments

packages/core/src/components/forms/numericInput.tsx

@@ -266,11 +266,11 @@ export class NumericInput extends AbstractPureComponent2<HTMLInputProps & INumer
     }
 
     private static getValue(props: INumericInputProps, stateValue: string) {
-        if (props.value != null) {
-            return props.value.toString();
-        } else {
+        if (props.value === null || props.value === undefined) {
             return stateValue;
         }
+
+        return props.value.toString();
     }
 
     private static roundAndClampValue(
@@ -331,13 +331,14 @@ export class NumericInput extends AbstractPureComponent2<HTMLInputProps & INumer
         const didMaxChange = this.props.max !== prevProps.max;
         const didBoundsChange = didMinChange || didMaxChange;
         const didLocaleChange = this.props.locale !== prevProps.locale;
+        const didValueChange = this.state.value !== prevState.value;
 
-        if ((didBoundsChange && this.state.value !== prevState.value) || didLocaleChange) {
+        if ((didBoundsChange && didValueChange) || didLocaleChange) {
             // we clamped the value due to a bounds change, so we should fire the change callback
             const valueAsString = parseStringToStringNumber(prevState.value, prevProps.locale);
             const localizedValue = toLocaleString(parseFloat(valueAsString), this.props.locale);
 
-            this.props.onValueChange?.(Number(valueAsString), localizedValue, this.inputElement);
+            this.props.onValueChange?.(+valueAsString, localizedValue, this.inputElement);
         }
     }
 
@@ -390,8 +391,9 @@ export class NumericInput extends AbstractPureComponent2<HTMLInputProps & INumer
         const { intent, max, min, locale } = this.props;
         const value = Number(parseStringToStringNumber(this.state.value, locale));
         const disabled = this.props.disabled || this.props.readOnly;
-        const isIncrementDisabled = max !== undefined && +value >= max;
-        const isDecrementDisabled = min !== undefined && +value <= min;
+        const isIncrementDisabled = max !== undefined && value >= max;
+        const isDecrementDisabled = min !== undefined && value <= min;
+
         return (
             <ButtonGroup className={Classes.FIXED} key="button-group" vertical={true}>
                 <Button

packages/core/src/components/forms/numericInputUtils.ts

@@ -29,9 +29,7 @@ function getDecimalSeparator(locale: string) {
     return result && result[1] || ".";
 }
 
-export function toLocaleString(num: number, locale?: string) {
-    locale = locale || "en-US";
-
+export function toLocaleString(num: number, locale: string = "en-US") {
     return sanitizeNumericInput(num.toLocaleString(locale), locale);
 }
 
@@ -48,14 +46,15 @@ export function getValueOrEmptyValue(value: number | string = "") {
 }
 
 function transformLocalizedNumberToStringNumber(character: string, locale: string) {
-    const charactersMap = new Array(10).fill("").map((_value, index) => index.toLocaleString(locale));
-    const jsNumber = charactersMap.indexOf(character);
+    const jsNumber = new Array(10).fill("")
+        .map(value => value.toLocaleString(locale))
+        .indexOf(character);
 
-    if (jsNumber !== -1) {
-        return jsNumber;
-    } else {
+    if (jsNumber === -1) {
         return character;
     }
+
+    return jsNumber;
 }
 
 export function parseStringToStringNumber(value: number | string, locale: string | undefined): string {