Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[table] refactor: replace force-hardware-acceleration mixin with "will-change: transform" #4356

Merged

Conversation

cemreyavuz
Copy link
Contributor

Fixes #859

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Delete force-hardware-acceleration mixin and replace the places that this mixin is used with will-change: transform

Reviewers should focus on:

In the mentioned issue, it is said that this mixin is only used in table.scss. However, it turned out that it is also used in _quadrants.scss. Changes on that file should also be reviewed.

Screenshot

Because it is a refactor, there isn't any screenshot.

@cemreyavuz cemreyavuz changed the title [table] refactor: replace force-hardware-acceleration mixin with "willl-change: transform" [table] refactor: replace force-hardware-acceleration mixin with "will-change: transform" Oct 3, 2020
@@ -99,30 +99,8 @@ $pt-dark-intent-text-colors: (
@return $number;
}

@mixin force-hardware-acceleration() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a slight break for any Blueprint consumer who's reaching in to import @blueprintjs/core/src/common/mixins in Sass code, but that's not really part of our public API and a search across GitHub reveals that the break won't have any real impact, so I think it's ok.

@adidahiya adidahiya merged commit 0b3edfc into palantir:develop Oct 22, 2020
@alecf
Copy link
Contributor

alecf commented Oct 23, 2020

@adidahiya I'm glad to see the use of standard css, but one effect this has is that those of us who are still using version 3.7.x of @blueprintjs/table (due to issues like #3833 and #3779 ) can no longer upgrade @blueprintjs/core! Any chance you would release a 3.7.2 of @blueprintjs/table or give a timeline on fixing some of those table bugs?

@adidahiya
Copy link
Contributor

@alecf is this a critical CSS fix for you? I can give you a rough timeline of EOY (end of year) for the table 3.8.x issues milestone

@MartinDawson
Copy link

MartinDawson commented Mar 22, 2021

@adidahiya Hi adidahiya, is their an timeline on the #3833 fix? This seems to be a problem for quite a few people.

Thanks for all the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete force-hardware-acceleration() mixin when Chrome will-change bug fixed
4 participants