[core] feat: spread data-* props to HTML elements #4180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
suggested changes
Jun 16, 2020
Co-authored-by: Adi Dahiya <adi.dahiya14@gmail.com>
adidahiya
approved these changes
Jun 16, 2020
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3210
Checklist
Changes proposed in this pull request:
This PR changes
removeNonHTMLPropsso that it ignores any prop with hyphens. Typescript has a special rule to ignore hyphenated props (such asdata-foo) during JSX attribute validation. It is not common to use hyphenated attributes for React props, as those props are not valid JS identifiers, so it is best to assume that any prop with a hyphen is intended for the rendered element.https://www.typescriptlang.org/docs/handbook/jsx.html#attribute-type-checking
This will help in tests scenarios where data-attributes are used as test selectors.