Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webpack-build-scripts] upgrade dependencies #4084

Merged
merged 3 commits into from
Apr 22, 2020
Merged

[webpack-build-scripts] upgrade dependencies #4084

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2da48cc
[webpack-build-scripts] upgrade deps
adidahiya Apr 22, 2020
fab2b7e
[webpack-build-scripts] enable esModule option
adidahiya Apr 22, 2020
1c3044c
ensure copy-webpack-plugin is installed
adidahiya Apr 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[webpack-build-scripts] enable esModule option
  • Loading branch information
@adidahiya
adidahiya committed Apr 22, 2020
commit fab2b7ed9f7d85c79c132e9ae4921a219913544f
9 changes: 8 additions & 1 deletion packages/webpack-build-scripts/webpack.config.base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,18 @@ if (!IS_PRODUCTION) {
);
}

const extractPlugin = {
loader: MiniCssExtractPlugin.loader,
options: {
esModule: true,
},
};

// Module loaders for .scss files, used in reverse order:
// compile Sass, apply PostCSS, interpret CSS as modules.
const scssLoaders = [
// Only extract CSS to separate file in production mode.
IS_PRODUCTION ? MiniCssExtractPlugin.loader : require.resolve("style-loader"),
IS_PRODUCTION ? extractPlugin : require.resolve("style-loader"),
{
loader: require.resolve("css-loader"),
options: {
Expand Down