Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Incorrect selection of years on right side when clicking throu… #4066

Merged
merged 2 commits into from
Apr 21, 2020

Conversation

schopchyts
Copy link
Contributor

@schopchyts schopchyts commented Apr 15, 2020

…gh years on shortcuts while contiguousCalendarMonths=false

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Compare the entire dates and not only months

Reviewers should focus on:

Date range picker component

Screenshot

Before the fix:

image

image

image

After the fix:

image

image

image

image

…gh years on shortcuts while contiguousCalendarMonths=false
@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @schopchyts! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@schopchyts schopchyts closed this Apr 15, 2020
@schopchyts schopchyts reopened this Apr 15, 2020
@adidahiya
Copy link
Contributor

thanks @schopchyts, code change looks good. could you please add a unit test to verify this behavior? probably in the describe("left/right calendar when not contiguous", ...) test suite

@adidahiya adidahiya merged commit 0b526ca into palantir:develop Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants