Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal text to switch component #3327

Merged
merged 15 commits into from
Feb 6, 2019
Merged

Add internal text to switch component #3327

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e5e5f57
switch text v0
Jan 31, 2019
5c57b22
font size a bit smaller
Jan 31, 2019
e99a2f0
add an example of internal text property
Jan 31, 2019
52ce53e
test
Jan 31, 2019
e374c5a
cleanup
Jan 31, 2019
77ad2da
lint fixes
Jan 31, 2019
2e386d6
review comments
Feb 1, 2019
0432158
remove whitespace in tests
Feb 1, 2019
2b95fb7
more review comments
Feb 5, 2019
4852b8f
even more review changes
Feb 6, 2019
22f62ef
remove errant property
giladgray Feb 6, 2019
e0bd72f
restore comment
giladgray Feb 6, 2019
a054c46
update prop docs
giladgray Feb 6, 2019
e922672
additional tests
Feb 6, 2019
2b8ad86
remove unnecessary checks
Feb 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test
  • Loading branch information
Leah Anderson committed Jan 31, 2019
commit 52ce53e9e3e5f8b824c8a384a9cf67e2d9fbe0fc
9 changes: 8 additions & 1 deletion packages/core/test/controls/controlsTests.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,14 @@ describe("Controls:", () => {
});
});

controlsTests(Switch, "checkbox", Classes.SWITCH);
controlsTests(Switch, "checkbox", Classes.SWITCH, () => {
describe("internal text", () => {
const switchWithText = mount(<Switch activeText="Active Text" inactiveText="Inactive Text" />);
it("renders internal text", () => {
giladgray marked this conversation as resolved.
Show resolved Hide resolved
assert.equal(switchWithText.find(`.${Classes.SWITCH}-active-text`).text(), "Active Text");
});
});
});

controlsTests(Radio, "radio", Classes.RADIO);

Expand Down