Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] show optional isDarkTheme parameter in ContextMenu API docs #3273

Merged
merged 1 commit into from
Jan 9, 2019
Merged

[docs] show optional isDarkTheme parameter in ContextMenu API docs #3273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[docs] show optional isDarkTheme parameter in ContextMenu API docs 
To make it more obvious that you can manually create a dark context menu, as raised in #3229
  • Loading branch information
@adidahiya
adidahiya authored Jan 8, 2019
commit b7c9356d7e0d19a887276820052cb6220fcbeb9c
2 changes: 1 addition & 1 deletion packages/core/src/components/context-menu/context-menu.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ The imperative API provides a single static `ContextMenu` object, enforcing the
principle that only one context menu can be open at a time. This API is ideal
for programmatically triggered menus or for non-React apps.

- `ContextMenu.show(menu: JSX.Element, offset: IOffset, onClose?: () => void): void`
- `ContextMenu.show(menu: JSX.Element, offset: IOffset, onClose?: () => void, isDarkTheme?: boolean): void`

Show the given element at the given offset from the top-left corner of the
viewport. Showing a menu closes the previously shown one automatically. The
Expand Down