Blueprint Table #30

themadcreator · 2016-11-02T22:58:35Z

Blueprint Table is a highly configurable UI component that provides standard UX
for presenting tabular data. It is built using React but usable with any front end framework.

Features

Fixed column headers and row indices columns
Resizable columns and rows
- Double-click column resize handles for auto-sizing
Viewport-only rendering for scale (a.k.a. lazy rendering)
Robust selections (columns, rows, or multiple cell regions)
Right-click to copy cell region contents
Inline editable column headers & cells
Unit test covered
Documented
Feature gallery

Closes #8

Blueprint Table is a highly configurable UI component that provides standard UX for presenting tabular data. It is built using [React](https://facebook.github.io/react/) but usable with any front end framework. **Features** - Fixed column headers and row indices columns - Resizable columns and rows - Double-click column resize handles for auto-sizing - Viewport-only rendering for scale (a.k.a. _lazy_ rendering) - Robust selections (columns, rows, or multiple cell regions) - Right-click to copy cell region contents - Inline editable column headers & cells (/) Unit test covered (/) Documented (/) Feature gallery

giladgray · 2016-11-03T00:03:14Z

lint and test | Preview
_{core coverage | datetime coverage}

giladgray · 2016-11-03T00:10:37Z

make preview script run | Preview
_{core coverage | datetime coverage}

giladgray · 2016-11-03T00:18:44Z

invert preview conditional | Preview
_{core coverage | datetime coverage}

giladgray · 2016-11-03T00:18:46Z

invert preview conditional
feature gallery preview | perf preview | coverage

giladgray · 2016-11-03T00:46:06Z

add table preview to artifacts | Preview
_{core coverage | datetime coverage}

giladgray · 2016-11-03T00:46:54Z

add table preview to artifacts
feature gallery preview | perf preview | coverage

giladgray · 2016-11-03T00:59:42Z

fix preview hrefs | Preview
_{core coverage | datetime coverage}

giladgray · 2016-11-03T01:00:18Z

fix preview hrefs
feature gallery preview | perf preview | coverage

giladgray · 2016-11-03T19:31:37Z

update preview | Preview
_{core coverage | datetime coverage}

giladgray · 2016-11-03T19:32:19Z

update preview
table preview

giladgray · 2016-11-03T20:19:59Z

base64 encode fonts | Preview
_{core coverage | datetime coverage}

giladgray · 2016-11-03T20:20:37Z

base64 encode fonts
table preview

giladgray

looking good so far!

giladgray · 2016-11-03T22:18:52Z

packages/table/config/webpack.config.preview.js

                // We need to resolve to an absolute path so that this loader
                // can be applied to CSS in other projects (i.e. packages/core)
-                loader: require.resolve("file-loader") + "?publicPath:/preview/dist/&name=./resources/[hash].[ext]"
+                loader: require.resolve("base64-font-loader")


why? i've never had problems with file-loader for fonts.

the preview wasn't loading these resources, and i wasn't sure why, but i can revisit this.

giladgray · 2016-11-03T22:20:34Z

Gulpfile.js

@@ -41,6 +41,13 @@ const projects = [
        copy: {
            "src/index.html": { to: [""], base: "src/" },
        },
+    }, {
+        id: "table",
+        cwd: "packages/table",


trailing slash for consistency with other projects?

only docs has that slash, but i'll add it

oh whatever then

giladgray · 2016-11-03T22:21:36Z

packages/table/CONTRIBUTING.md

+
+## Developing
+
+Start a new feature branch. We use a format like `[category]/[short-name]`.


i'm not sure this file is helpful here... it's in a non-standard place (should be in root) and these rules don't line up with our actual practices of [initials]/[short-name]

a lot of this content should probably go in the package README itself.

CONTRIBUTING.md is the right place to talk about our expectations wrt pull-requests, so this seems appropriate. However, I agree it should be consistent for the whole repo, so i can move it into the top.

yes exactly we can have a root-level CONTRIBUTING to detail how to contribute to the whole thing. package-level notes can appear in each package's README.

giladgray · 2016-11-04T20:27:39Z

can we bring back the Table (React) docs and examples?

giladgray · 2016-11-08T01:25:57Z

fix docs table css

Preview: docs | landing | table
Coverage: core | datetime

adidahiya · 2016-11-08T02:08:10Z

... how/why are you getting blueprint-bot to commit for you?

themadcreator · 2016-11-08T18:03:18Z

I registered the blueprint-bot user to my work email, which my local git is configured with as the author field. I just need to change blueprint-bot's email, but I'm not sure which addr to use.

giladgray

got some questions but this looks good enough to merge.

just waiting for merge conflict resolution.

giladgray · 2016-11-08T23:02:19Z

packages/table/src/cell/cell.tsx

@@ -22,7 +22,7 @@ export interface ICellProps extends IIntentProps, IProps {

 export type ICellRenderer = (rowIndex: number, columnIndex: number) => React.ReactElement<ICellProps>;

-export const emptyCellRenderer = (rowIndex: number, columnIndex: number) => <Cell />;
+export const emptyCellRenderer = (_rowIndex: number, _columnIndex: number) => <Cell />;


anything wrong with () => <Cell /> ?

I really prefer to use the correct signature here.

giladgray · 2016-11-08T23:03:22Z

packages/table/src/cell/editableCell.tsx

@@ -70,7 +70,7 @@ export class EditableCell extends React.Component<IEditableCellProps, {}> {
        this.cellElement = ref;
    }

-    private handleCellDoubleClick = (event: MouseEvent) => {
+    private handleCellDoubleClick = (_event: MouseEvent) => {


can you just leave off these unused args? shouldn't affect typings; functions can always be implemented with fewer args.

giladgray · 2016-11-08T23:03:57Z

packages/table/tsconfig.json

@@ -14,7 +14,8 @@
  },
  "include": [
    "typings/tsd.d.ts",
-    "src/**/*"
+    "src/**/*",
+    "preview/*.d.ts"


style nit: i prefer putting .d.ts files before sources

blueprint-bot · 2016-11-09T00:41:03Z

lint

Preview: docs | table
Coverage: core | datetime

…able

blueprint-bot · 2016-11-09T01:01:34Z

Merge branch 'master' of github.com:palantir/blueprint into project/table

Preview: docs | table
Coverage: core | datetime

* Blueprint Table Blueprint Table is a highly configurable UI component that provides standard UX for presenting tabular data. It is built using [React](https://facebook.github.io/react/) but usable with any front end framework. **Features** - Fixed column headers and row indices columns - Resizable columns and rows - Double-click column resize handles for auto-sizing - Viewport-only rendering for scale (a.k.a. _lazy_ rendering) - Robust selections (columns, rows, or multiple cell regions) - Right-click to copy cell region contents - Inline editable column headers & cells - Unit test covered - Documented - Feature gallery

themadcreator added the Status: work in progress label Nov 2, 2016

themadcreator added 3 commits November 2, 2016 16:00

omit error in yaml

5668438

update dependencies

0c32fdb

lint and test

b959ec0

make preview script run

ba1b1bb

invert preview conditional

928efde

add table preview to artifacts

7553199

fix preview hrefs

cfa803b

update preview

d3a28f2

base64 encode fonts

a071343

themadcreator added needs review and removed Status: work in progress labels Nov 3, 2016

giladgray reviewed Nov 3, 2016

View reviewed changes

themadcreator added 3 commits November 4, 2016 12:12

Merge remote-tracking branch 'origin/master' into project/table

86803f4

switch to file loader

85d2499

move contributing.md to top level

5112f65

themadcreator added 7 commits November 7, 2016 13:59

Merge remote-tracking branch 'origin/master' into project/table

9e2bbcd

Add back table examples to docs. Interfaces not showing up

350c817

merge

9c146f7

Update preview script for table

1fdfaa3

Update circle artifacts

5e415f7

try adding table dist to artifacts to fix docs styles

3db7de7

fix docs table css

a5ee84c

giladgray approved these changes Nov 8, 2016

View reviewed changes

themadcreator added 4 commits November 8, 2016 16:25

merge

701cb29

Also fix table preview diff

bb9caf0

JSON nit

9a5297d

lint

09e17d4

Merge branch 'master' of github.com:palantir/blueprint into project/t…

fb9116f

…able

themadcreator merged commit c39ae71 into master Nov 9, 2016

themadcreator deleted the project/table branch November 9, 2016 01:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Blueprint Table #30

Blueprint Table #30

themadcreator commented Nov 2, 2016 •

edited

Loading

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray left a comment

giladgray Nov 3, 2016

themadcreator Nov 4, 2016

giladgray Nov 3, 2016

themadcreator Nov 4, 2016

giladgray Nov 4, 2016

giladgray Nov 3, 2016

giladgray Nov 3, 2016

themadcreator Nov 4, 2016

giladgray Nov 4, 2016

giladgray commented Nov 4, 2016

giladgray commented Nov 8, 2016

adidahiya commented Nov 8, 2016

themadcreator commented Nov 8, 2016

giladgray left a comment •

edited

Loading

giladgray Nov 8, 2016

themadcreator Nov 9, 2016

giladgray Nov 8, 2016

giladgray Nov 8, 2016

blueprint-bot commented Nov 9, 2016

blueprint-bot commented Nov 9, 2016


		## Developing

		Start a new feature branch. We use a format like `[category]/[short-name]`.

Blueprint Table #30

Blueprint Table #30

Conversation

themadcreator commented Nov 2, 2016 • edited Loading

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray commented Nov 3, 2016

giladgray left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

giladgray commented Nov 4, 2016

giladgray commented Nov 8, 2016

fix docs table css

adidahiya commented Nov 8, 2016

themadcreator commented Nov 8, 2016

giladgray left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

blueprint-bot commented Nov 9, 2016

lint

blueprint-bot commented Nov 9, 2016

Merge branch 'master' of github.com:palantir/blueprint into project/table

themadcreator commented Nov 2, 2016 •

edited

Loading

giladgray left a comment •

edited

Loading