Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon] fix font icons on IE11 #2927

Merged
merged 1 commit into from
Sep 12, 2018
Merged

[Icon] fix font icons on IE11 #2927

merged 1 commit into from
Sep 12, 2018

Conversation

giladgray
Copy link
Contributor

Fixes #2918

Changes proposed in this pull request:

  • seems as though IE does not properly support CSS unset keyword.

@@ -13,8 +13,10 @@

&:not(:empty)::before {
// clear font icon when there's an <svg> image
// stylelint-disable-next-line declaration-no-important
// stylelint-disable
content: "" !important; // fallback for IE11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IE!!!! 😡

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so nasty

@giladgray giladgray merged commit 0dd7d6d into develop Sep 12, 2018
@giladgray giladgray deleted the gg/icon-ie branch September 12, 2018 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants