[table] Adjust Truncated Popover Behavior #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `TruncatedFormat` cell would display a popover target with the "..." icon when its text content was longer than the `truncationLength` prop. Cells that weren't truncated this way used a CSS "text-overflow: ellipsis" rule, which lead to the odd sight of a mixture of "..." in the cells. This change alters the default behavior to always show the large "..." icon even if the cell's text content isn't truncated. Therefore the look of the cells will be much more consistent. Also, the `JSONFormat` cell will turn off the "..." popover target for nully values.
|
Fixes #232 |
cmslewis
reviewed
Nov 29, 2016
| @@ -32,35 +48,42 @@ export interface ITruncatedFormatProps extends IProps { | |||
| * @default "..." | |||
| */ | |||
| truncationSuffix?: string; | |||
|
|
|||
There was a problem hiding this comment.
nit: do we need this newline?
| @@ -38,15 +38,28 @@ export class JSONFormat extends React.Component<IJSONFormatProps, {}> { | |||
|
|
|||
| public render() { | |||
| const { children, omitQuotesOnStrings, stringify } = this.props; | |||
|
|
|||
| const isNully = children === undefined || children === null; | |||
There was a problem hiding this comment.
nit: the conventional style in Blueprint seems to be to do a double-equal comparison for null/undefined checks:
const isNully = children == null;
There was a problem hiding this comment.
== null is the only valid case of double-equals cuz it performs both of the checks you've done here
| @@ -10,6 +10,12 @@ import * as classNames from "classnames"; | |||
| import * as PureRender from "pure-render-decorator"; | |||
| import * as React from "react"; | |||
|
|
|||
| export enum TruncatedPopover { | |||
There was a problem hiding this comment.
I'd prefer a clearer noun here; the core package has conditioned me to expect any Popover to be a React component. Maybe something like TruncatedPopoverScheme or TruncationScheme?
giladgray
changed the title
giladgray
reviewed
Nov 29, 2016
| switch (showPopover) { | ||
| case TruncatedPopoverMode.ALWAYS: | ||
| return true; | ||
| case TruncatedPopoverMode.NEVER: |
There was a problem hiding this comment.
could get away without this case since it's also the default 😄
There was a problem hiding this comment.
well we can, but i like to have all explicit enum values AND a default fallthrough
giladgray
approved these changes
Nov 29, 2016
Merged
greglo
pushed a commit
to greglo/blueprint
that referenced
this pull request
Dec 12, 2016
* Adjust Truncated Popover Behavior Previously, the `TruncatedFormat` cell would display a popover target with the "..." icon when its text content was longer than the `truncationLength` prop. Cells that weren't truncated this way used a CSS "text-overflow: ellipsis" rule, which lead to the odd sight of a mixture of "..." in the cells. This change alters the default behavior to always show the large "..." icon even if the cell's text content isn't truncated. Therefore the look of the cells will be much more consistent. Also, the `JSONFormat` cell will turn off the "..." popover target for nully values. * PR Comments * Missed one instance of old name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Changes
Previously, the
TruncatedFormatcell would displaya popover target with the "..." icon when its text
content was longer than the
truncationLengthprop.Cells that weren't truncated this way used a CSS
"text-overflow: ellipsis" rule, which lead to
the odd sight of a mixture of "..." in the cells.
This change alters the default behavior to always
show the large "..." icon even if the cell's text
content isn't truncated. Therefore the look of the
cells will be much more consistent.
Also, the
JSONFormatcell will turn off the"..." popover target for nully values.