Controllable selection #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds "selectedRegions" prop to Table to allow to user to take over control of selection. If defined, the user will be responsible for updating the selection and should probable add a "onSelection" callback. Adds "selectedRegionTransform" prop to table to allow users to transform the selection region. This allows users to, for example, select a whole row when the user clicks on a single cell. Using a transform is advantageous because we can still handle interaction semantics like multiselect, meta-click, and click-to-deselect.
|
Take a look at the preview example "Row Transformed Controlled Selection" |
cmslewis
approved these changes
Nov 29, 2016
| @@ -286,12 +320,15 @@ export class Table extends AbstractComponent<ITableProps, ITableState> { | |||
| newRowHeights = Utils.arrayOfLength(newRowHeights, numRows, defaultRowHeight); | |||
| newRowHeights = Utils.assignSparseValues(newRowHeights, rowHeights); | |||
|
|
|||
| const newselectedRegions = (selectedRegions == null) ? this.state.selectedRegions : selectedRegions; | |||
There was a problem hiding this comment.
nit: newselectedRegions => newSelectedRegions
| // clicking adds transformed selection | ||
| table.find(CELL_SELECTOR).mouse("mousedown").mouse("mouseup"); | ||
|
|
||
| expect(onSelection.called).to.equal(true); |
There was a problem hiding this comment.
nit: I tend to prefer expect(onSelection.called).to.be.true syntax for boolean checks, because it reads a little more like plain English.
|
Yep, I agree with your nits @cmslewis, so i'll merge once this builds |
|
When will this feature become available? We can't wait... :) |
|
we should be able to make a release including this feature today. |
This was referenced Dec 2, 2016
Merged
greglo
pushed a commit
to greglo/blueprint
that referenced
this pull request
Dec 12, 2016
* Controllable selection Adds "selectedRegions" prop to Table to allow to user to take over control of selection. If defined, the user will be responsible for updating the selection and should probable add a "onSelection" callback. Adds "selectedRegionTransform" prop to table to allow users to transform the selection region. This allows users to, for example, select a whole row when the user clicks on a single cell. Using a transform is advantageous because we can still handle interaction semantics like multiselect, meta-click, and click-to-deselect. * PR Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Related: #191
What changes did you make?
Adds "selectedRegions" prop to Table to allow to user to take over
control of selection. If defined, the user will be responsible for
updating the selection and should probable add a "onSelection"
callback.
Adds "selectedRegionTransform" prop to table to allow users to
transform the selection region. This allows users to, for example,
select a whole row when the user clicks on a single cell. Using
a transform is advantageous because we can still handle interaction
semantics like multiselect, meta-click, and click-to-deselect.