Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3.0 upgrade script; improve 2.0 script #2488

Merged
merged 2 commits into from
May 16, 2018
Merged

Add 3.0 upgrade script; improve 2.0 script #2488

merged 2 commits into from
May 16, 2018

Conversation

jkillian
Copy link
Contributor

@jkillian jkillian commented May 11, 2018 •
edited
Loading

Changes proposed in this pull request:

Changes to 2.0 script:

  • rename IconClasses when used in a NIS visual
  • only warn about remaining uses of IconClasses, trying to replace it with invalid TS just ends badly

New 3.0 script:

  • Same functions and help docs as 2.0. (Sidenote: I think we should've just done these in node.js instead of bash for more cross-platform compat, but too late now)
  • Handles NIS visual -> icon
  • Renames classes to Classes.HEADING

@jkillian jkillian requested a review from giladgray May 11, 2018 16:40
@blueprint-bot
Copy link

add blueprint 3.0 upgrade script

Preview: documentation | landing | table

jkillian
jkillian commented May 11, 2018
View reviewed changes
packages/core/scripts/upgrade-blueprint-3.0.0-rename

Renames for @blueprintjs/core"
renameProp visual icon
renameString "Classes\.CALLOUT_TITLE" "Classes.HEADING"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't actually test these class renames, maybe I should before we merge?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can always do follow ups and stuff, but let's make sure it works before merging yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested manually, seems to work correctly 👍

@giladgray giladgray merged commit b21e2c6 into develop May 16, 2018
@giladgray giladgray deleted the jk/upgrade30 branch May 16, 2018 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llorca llorca llorca left review comments

@giladgray giladgray giladgray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkillian @blueprint-bot @llorca @giladgray