change CSS namespace to bp3
#2441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change CSS namespace to `bp3`Preview: documentation | landing | table |
llorca
reviewed
May 1, 2018
| @@ -4,8 +4,7 @@ | |||
| @import "generated/icon-variables"; | |||
| @import "generated/icon-map"; | |||
|
|
|||
| $pt-namespace: "pt" !default; | |||
| $ns: $pt-namespace; | |||
| $ns: "bp3" !default; | |||
There was a problem hiding this comment.
can we not import that from core? how does it work for other packages that contain CSS?
There was a problem hiding this comment.
❌ other way around... core depends on icons!
There was a problem hiding this comment.
oh right, I forget. is that tentatively changing to icons depends on core with tree-shaked SVG icons?
There was a problem hiding this comment.
nope no such plans. still core > icons
add _reset.scss for limited global stylesPreview: documentation | landing | table |
llorca
reviewed
May 7, 2018
| } | ||
|
|
||
| strong { | ||
| font-weight: 600; |
llorca
approved these changes
May 7, 2018
themadcreator
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changing the CSS namespace prevents conflicts between Blueprint 1.x and 3.x elements.
add
_reset.scssfile for limited global resets:body,p,strong,smallTODO
<p>tags<h4>tags inCallout,Dialog,NISClasses.HEADING instead of custom classes #2443, refactor NonIdealState: fewer classes, simple styles #2445<strong>font weight to 600 (medium)