Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Labs] Suggest component #1499

Merged
merged 14 commits into from
Aug 29, 2017
Merged

[Labs] Suggest component #1499

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7f0e1f2
Initial Suggest implementation
Aug 24, 2017
00169b7
Update docs
Aug 24, 2017
7b6fddf
Clarify double ternary
Aug 24, 2017
ed46d34
closeOnSelect is true by default
Aug 24, 2017
e99c7d5
Address comments
Aug 24, 2017
d9cf645
Add openOnKeyDown prop
Aug 24, 2017
20054a3
Fix errors
Aug 24, 2017
cfcd57a
Update docs
Aug 24, 2017
0f4dc5a
Set proper state and fix keyDown handler
Aug 26, 2017
0affb8f
Write test stubs for Suggest
cmslewis Aug 29, 2017
9180678
Add tests
cmslewis Aug 29, 2017
e614ac1
Fix typo in selectTests.tsx
cmslewis Aug 29, 2017
d6650d0
Move listeners to <InputGroup>, write more tests
cmslewis Aug 29, 2017
18cbbfc
Fix param name
cmslewis Aug 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo in selectTests.tsx
  • Loading branch information
@cmslewis
cmslewis committed Aug 29, 2017
commit e614ac10784aa7dd4f48c382d3112fbe5eed2944
2 changes: 1 addition & 1 deletion packages/labs/test/selectTests.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ describe("<Select>", () => {
assert.lengthOf(wrapper.find("address"), 1, "should find noResults");
});

it("clicking item invokes onSelectItem", () => {
it("clicking item invokes onItemSelect", () => {
const wrapper = select();
wrapper.find("a").at(4).simulate("click");
assert.strictEqual(handlers.onItemSelect.args[0][0], TOP_100_FILMS[4]);
Expand Down