Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs2 NPEs if passed null amongst children. #838

Closed
AndyMoreland opened this issue Mar 14, 2017 · 2 comments
Closed

Tabs2 NPEs if passed null amongst children. #838

AndyMoreland opened this issue Mar 14, 2017 · 2 comments
Labels
Package: core Type: bug
Milestone
1.13.0

Comments

@AndyMoreland
Copy link

AndyMoreland commented Mar 14, 2017 •
edited
Loading

Goal: conditionally render a tab.

Bug report

  • Package version(s): 1.11.1

Steps to reproduce

<Tabs2>
{ null }
</Tabs2>

Actual behavior

Exception

Uncaught TypeError: Cannot read property 'type' of null
    at isTab

Expected behavior

Don't render the tab.
@giladgray giladgray added this to the 1.13.0 milestone Mar 15, 2017
@giladgray
Copy link
Contributor

😱 and i'll bet undefined doesn't work either from looking at the code

@AndyMoreland
Copy link
Author

yeah most likely! :-)

giladgray pushed a commit that referenced this issue Mar 17, 2017
two failing tests for #838, #841
c79d2be
giladgray pushed a commit that referenced this issue Mar 17, 2017
isTab checks existence first, fixes #838
a305643
@giladgray giladgray mentioned this issue Mar 17, 2017
Merged
@giladgray giladgray mentioned this issue Mar 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: core Type: bug
Projects
None yet
Milestone
1.13.0
Development

No branches or pull requests
3 participants
@AndyMoreland @llorca @giladgray