Setting button icon intent does not change icon color in dark mode

[tomshen]

Environment

• Package version(s): 3.15.1 (but can repro in 3.18.0)
• Browser and OS versions: macOS 10.14.6, Chrome 76

Repro: https://codesandbox.io/embed/blueprint-sandbox-0egjl

Steps to reproduce

1. Create a container with Classes.DARK.
2. Create a button inside that container.
3. Set the button's icon to <Icon icon="tick-circle" intent="success" />.

Actual behavior

Expected behavior

Possible solution

Change selector specificity:

[adidahiya]

I think it depends on the context of the icon. See #3597, #3598, #3355

Adjusting title to reflect that the problem is with icons inside buttons (which rarely need custom colors...) nvm it was already correct

[DeepakSinghKapKoti]

Yea its a bug I think the intents are not reflecting but I found a way to reflect intents to icon now

<Button id={...} text={...} icon = {<Icon icon={this.props.icon} style={{color:"red"}}>} />

the intent will not work but we can have our own css, which will work on icon only.