Skip to content

Proposal: rename inline=false to portal=true #1341

Closed
@giladgray

Description

What is "inline" really? This name has been confusing since the beginning, and we often talk about non-inlined Popovers, etc.

Implementationally, inline={false} means "render in a Portal to remove from DOM flow."

I therefore propose a new name for the prop: portal={true}. This makes the semantics obvious. Enabling portal will render the children inside a Portal; disabling will not use a Portal (preserving DOM flow). Boom done.

Metadata

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions