Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better UI #94

Closed
roguh opened this issue Aug 22, 2018 · 19 comments
Closed

Better UI #94

roguh opened this issue Aug 22, 2018 · 19 comments

Comments

@roguh
Copy link

roguh commented Aug 22, 2018

Are there any plans for improving the user interface?

Although I think the interface is well thought-out, I think it could still use some graphical improvements. The only actual issue I have is that the addon does not work well on Firefox on Android; the door hanger is actually opened in another tab so everything looks too small.

I plan to work on some improvements I have in mind, including on fixing this issue on Android. I'm posting this issue to keep track of any progress on this.

@roguh
Copy link
Author

roguh commented Aug 22, 2018

Here are some screenshots:

screenshot_20180821-220338
screenshot_20180821-220252

@palant
Copy link
Owner

palant commented Sep 28, 2018

The scaling seemed fine to me when I tried the extension on Firefox for Android, but I'll try again to see whether I can reproduce this issue. In general, more significant UI changes are planned. In particular, I want a tool selection on the left side indicating where you are right now - search, password list or sync settings.

@adrium
Copy link

adrium commented Sep 29, 2018

What do you think about the interface of https://github.com/adrium/easypass ? (Try the chrome extension)

@palant
Copy link
Owner

palant commented Oct 2, 2018

I suggest that you stop spamming. This is largely about the way the user interface looks in Firefox Mobile - which is the only mobile browser to support extensions. You are free to do your Chrome-only fork, but please don't add noise to my issues.

@roguh
Copy link
Author

roguh commented Oct 2, 2018

Pardon me. Feel free to delete this issue

@roguh roguh closed this as completed Oct 2, 2018
@roguh
Copy link
Author

roguh commented Oct 2, 2018

Wait, I thought you were calling the issue spam, not the comment.

As an update, I think #91 might be a more general fix. I only want a way to access this password manager on mobile.

On another note, the Firefox UX is almost ok. When I tap on any text input, the display zooms in to a reasonable level.

@roguh roguh reopened this Oct 2, 2018
@roguh
Copy link
Author

roguh commented Oct 2, 2018

This was most recently reproduced on Firefox Beta 63.09b on Android.

@palant
Copy link
Owner

palant commented Oct 2, 2018

Sorry about it, when I talked about spam I meant #94 (comment) of course.

@javenschuetz
Copy link

my 2 cents on the UI is that some minimal keyboard shortcuts would be an important addition. IIRC, bitwarden uses ctrl+shift+L to auto-fill and it makes a huge difference in usability. I don't really care about a fancy ui besides this.

(Pardon me if the shortcut already exists, I spent some time trying to find it earlier today and even grepped through the codebase very briefly)

@palant
Copy link
Owner

palant commented May 14, 2019

Landed a massive change refactoring the panel on top of the Vue.js framework. This is an important prerequisite for UI improvements as the complexity was getting prohibitive here. Also, some UI improvements have been implemented in this step already, e.g. quite a few UI pieces are modal overlays now.

Pardon me if the shortcut already exists

See #43 (comment)

palant added a commit that referenced this issue May 31, 2019
…swords links there. Also made it more obvious which icon in the password list is being hovered.
@palant
Copy link
Owner

palant commented May 31, 2019

Forgot to reference this issue in 087a285, it belongs here.

palant added a commit that referenced this issue May 31, 2019
palant added a commit that referenced this issue May 31, 2019
…l way via add-on management isn't very discoverable
@palant
Copy link
Owner

palant commented May 31, 2019

Here is how it looks now:

screenshot

palant added a commit that referenced this issue Jun 1, 2019
…container, now that there is no Cancel button there
@palant
Copy link
Owner

palant commented Jun 1, 2019

And slightly differently now after addressing #101 (website name is a link):

screenshot

@palant palant closed this as completed in 49108c9 Jun 1, 2019
@palant
Copy link
Owner

palant commented Jun 1, 2019

The scaling issue as reported initially should be fixed as well now.

@palant
Copy link
Owner

palant commented Jun 1, 2019

Unfortunately, I don't see any way to improve display of options, this one is controlled by Firefox itself. When viewing options within PfP user interface, it works fine however.

@jotaf98
Copy link

jotaf98 commented Jun 3, 2019

The new UI looks great! When can we expect it to land?

Perhaps more importantly, does it fix the scaling issues in Firefox for Android? The addon is pretty functional there, but having to zoom in PfP's overlay on an otherwise mobile-friendly page to click tiny buttons is not great.

@palant
Copy link
Owner

palant commented Jun 3, 2019

As I said above:

The scaling issue as reported initially should be fixed as well now.

I hope to have the release ready within two weeks, there are still two major changes outstanding.

@jotaf98
Copy link

jotaf98 commented Jun 3, 2019

Alright, sorry I missed that part. Glad to hear it! Thanks for the amazing password manager by the way!

@Auronius
Copy link

Auronius commented Jun 4, 2019

I hope to have the release ready within two weeks, there are still two major changes outstanding.

I already merged all my passwords to PfP. I am waiting for new release with updated interface.

Thanks for the amazing password manager by the way!

Yes, PfP is great password manager!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants