Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow npm-install and yarn-install to request python to build dependencies #928

Closed
wants to merge 2 commits into from

Conversation

c0d1ngm0nk3y
Copy link

@c0d1ngm0nk3y c0d1ngm0nk3y commented Aug 16, 2024

see #691

prerequisite: paketo-buildpacks/npm-install#753 - needed to actually request cpython when needed

Summary

Allow npm-install and yarn-install to request cpython if needed during build (dependency to node-gyp).

Use Cases

You don't have to use the full stack as soon as your app has a dependency to node-gyp

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@c0d1ngm0nk3y
Copy link
Author

This pr would not hurt, but probably does not make sense until paketo-buildpacks/npm-install#753 is in and npm-install can actually request cpython. On the other hand, this should already be in when the first request for cpython comes.

@mhdawson Thoughts?

@c0d1ngm0nk3y
Copy link
Author

I have added an integration test that will fail until paketo-buildpacks/npm-install#753 is consumed to actually request cpython.

@mhdawson mhdawson added the semver:minor A change requiring a minor version bump label Sep 13, 2024
@mhdawson
Copy link
Member

@c0d1ngm0nk3y from your last comment and the failing tests I assume this is waiting on #753, right?

@c0d1ngm0nk3y
Copy link
Author

I will close this for now ince the use case is quite limited (see comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants