Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBOM via packit v2 #296

Closed
wants to merge 2 commits into from

Conversation

TisVictress
Copy link
Contributor

SBOM implementation for mod vendor
Resolves #13

@@ -32,13 +41,31 @@ func Build(buildProcess BuildProcess, logs scribe.Emitter) packit.BuildFunc {
return packit.BuildResult{}, err
}

modCacheLayer.Launch = true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TisVictress What was the motivation behind making the modules cache layer available at launch time?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some more investigating and realized that it's currently not possible to access the SBOMs for layers that aren't marked for launch. See this conversation on a lifecycle issue implementing SBOM support. That means that currently, there's no way for an end user to access the SBOM generated by this buildpack unless the layer is marked for launch. (I'm guessing you already know this and it's why you marked the layer for launch?)

I don't think we should change this buildpack to mark the modules layer for launch – for security/hardening and optimization reasons we don't want the modules layer present in the app image. But unfortunately I think that means there's no way to test or use this feature until the lifecycle and/or pack makes the build SBOM available 😞 .

Copy link
Contributor Author

@TisVictress TisVictress Jan 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fg-j I needed to be able to test that the BOM files exist in the integration test.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I pinged CNB folks about this, and it looks like there's now an PR to enable grabbing build-time BOMs: buildpacks/pack#1359

Since this work is blocked anyway, let's wait to see if the build-BOM feature lands soon. That way we can integration test without changing the API of the buildpack.

@fg-j fg-j mentioned this pull request Feb 28, 2022
5 tasks
@fg-j
Copy link

fg-j commented Feb 28, 2022

Closing in favor of #311

@fg-j fg-j closed this Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we expose the go modules in the BOM?
2 participants