Add image insertion support to codepress #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansinnott
commented
Mar 11, 2020
bonham000
approved these changes
Mar 12, 2020
packages/client/codepress/src/app.ts
Outdated
| const filename = `${file.md5}_${file.name}`; | ||
| const filepath = path.join(absDir, filename); | ||
|
|
||
| console.log(`[UPLOAD] saving file for ${req.params.resourceId} at `); |
There was a problem hiding this comment.
Is this supposed to log the filename, e.g. at ...? ?
| console.log(`[UPLOAD] saving file for ${req.params.resourceId} at `); | ||
| file.mv(filepath, err => { | ||
| if (err) { | ||
| next(err); |
There was a problem hiding this comment.
Would this still result in res.send getting called later on line 142?
There was a problem hiding this comment.
Oh good call. I don't think so, but even if not it's not obvious so I'll add an early return
| @@ -294,6 +313,13 @@ class ContentEditor extends React.Component<Props> { | |||
| .toPromise(); | |||
| }; | |||
|
|
|||
| handleFileUpload = (file: File): Promise<string> => { | |||
| if (!this.props.challengeId) { | |||
There was a problem hiding this comment.
Would it make sense to move the error checking to the uploadFile method?
Not a big deal if it stays here.
There was a problem hiding this comment.
Yeah that would work too. Will update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does:
public/directory of the client projectThe rationale behind the second point is that we ideally want any images or
assets of any kind associated with challenges to be available as long as the
challenges are. For this reason using external URLs is less appealing than it
otherwise might be.
The alternative to this would be dropping images into a google storage bucket,
however that would require codepress users to be authorized with gcloud which is
a whole nother can of worms that I'd rather avoid for now.
NOTE: There are a few issues with the implementation...
This second point sucks, and I'm not sure what's going on there however my guess
is that rich-markdown-editor is rendering the image in such a way that the key
is prone to change often. I saw this in the inspector, although I'm not sure it's
the issue.
However, I'd still like to ship this even with caveats because we do not upload
many images and even when the editor does break the output markdown is correct
and it is read back correctly meaning it is not a user facing bug from what I
can tell.