-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add content covering scopes topic #68
Conversation
One other thing to note here is I sort of combined the ideas of global/local scope with "global" objects like Always possible to revisit and change or expand the content so I just went with what I had already to keep moving forward. I also touched on modules and libraries/dependencies in the end with a media challenge, since I think these are a bit of a conceptual extension of the idea of scope. |
Yeah, I think external linking is good at least for now. My thoughts longer term are that everything or nearly everything within challenges would link to the super concise glossary definition and then if they wanted more there would be a link in the glossary for the external sources. I think inverse to the courses almost every glossary entry would have at external links in the vein of citations
100% agree. I've thought about this too on multiple occasions. @bonham000 do you know if/how we can add our own definitions to the editor? Maybe something like you did with JSX.
Ah maybe it's accidentally JS. I don't remember at the time choosing against TS so this may have just been to get things up and running: f1a3b5a#diff-0b2bd454ff982feaebf5a10aece10317R45 |
Good point about the On the sample test message string I may go ahead and merge this but we can always change that again if we need to. |
The only thing about the typescript test editor is that ideally we don't have to add types to anything. The challenge tests are meant to be written quickly and iterated on quickly, not necessarily be rock solid code since nothing else depends on it and we're check it's validity in the browser as we work on it. If typescript starts yelling about implicit |
I agree @iansinnott, but also, it would be convenient if we could somehow add types for the global test methods which are available in the test environment. |
This PR:
Notes/Observations:
__user_code_string__
.'types' can only be used in a .ts file.
and I could not assign types to values. I also find the theme colors in the test editor to be different than the main editor.