Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring & Debugging Content #251

Merged
merged 24 commits into from
Nov 6, 2020
Merged

Conversation

bonham000
Copy link
Contributor

This PR:

  • Add a few basic challenges+videos for the Refactoring & Debugging module, and one project idea.
  • Implement a fix for adding workspace type definitions to the Monaco editor on challenge initial load with an editor "on mount" callback. Previously type definitions would not be added and this would result in type errors in the editor.

@bonham000 bonham000 added 📚 content Adding or updating course content 🔩 fix/improvement Some minor chore labels Nov 6, 2020
@bonham000 bonham000 requested a review from iansinnott November 6, 2020 05:50
@bonham000 bonham000 self-assigned this Nov 6, 2020
@iansinnott
Copy link
Member

Awesome, thanks. Yeah, please do merge

@bonham000 bonham000 merged commit afce832 into master Nov 6, 2020
@bonham000 bonham000 deleted the content/debugging-and-refactoring branch November 6, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 content Adding or updating course content 🔩 fix/improvement Some minor chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants