Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Current Challenge ID to be null #235

Merged
merged 8 commits into from
Sep 14, 2020
Merged

Conversation

bonham000
Copy link
Contributor

@bonham000 bonham000 commented Sep 14, 2020

This PR:

Notes:

This removes the default fallback for the initial challenge as the first in the course, unless that id is specified in the URL which loads the app. I think our Google ad redirects to /workspace/, which will now redirect to /home instead. If that's the case, we could either:

  1. Allow that to happen, /home is also a sensible starting place.
  2. Just change the ad to redirect to /workspace/iSF4BNIl or /workspace/iSF4BNIl/hello-pairwise.

@bonham000 bonham000 changed the title Current Chaell Allow Current Challenge ID to be null Sep 14, 2020
@bonham000 bonham000 self-assigned this Sep 14, 2020
@bonham000 bonham000 added the 🔩 fix/improvement Some minor chore label Sep 14, 2020
@iansinnott
Copy link
Member

which will now redirect to /home

Why? Since it's still doing a redirect, why not keep it redirecting to the first challenge?

I think we would see huge dropoff if we sent the add to /home. That page doesn't sit you down and demand you write some code—the workspace does. I'm not opposed to testing it though. I realize the predicted dropoff is just a guess, and we could get real data.

@bonham000
Copy link
Contributor Author

bonham000 commented Sep 14, 2020

Because the previous redirect occurred using the currentChallengeId which defaulted to the first challenge. Changing this and allowing it to be null instead breaks that redirect (if it's null), so I just changed it to default to /home if that occurs.

I think instead of hard-coding the redirect to go to the first challenge we should check where the ad actually links to and if we want to link to the first challenge we should just use that link.

I don't really have any preference on where the ad links to. The first challenge is great because it's the fastest route to getting started, but linking to /home might also be useful. This would be a good place to do an experiment and see which one leads to better initial engagement (but honestly I don't have a strong preference either way currently).

Copy link
Member

@iansinnott iansinnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but honestly I don't have a strong preference either way

OK, well my i'd favor not directing the user to the /home page yet.

I did change the ad to route to the first challenge directly.

/workspace might redirect to to the first challenge for logged-out users and /dashboard (which doesn't exist) for logged in users, or something along those lines.

I'm not against having a /home page, but I don't see the value in our current /home page from a user perspective.

All that being said, who knows maybe it would bump our sales. The ad won't be affected so do what you will.

@bonham000
Copy link
Contributor Author

I agree there's not a lot of meaningful functionality in the home route at the moment, but in my mind it was more like a placeholder for the dashboard in the future.

We can definitely change the default redirects, just in refactoring the code here it became more simple to remove the default challenge logic altogether which resulted in this side effect related to the ad (but simpler code, I thought).

Also, totally fine about keeping the first challenge - if I had to choose one for the ad redirect it would be the first challenge.

@bonham000 bonham000 merged commit 7bcdb07 into master Sep 14, 2020
@bonham000 bonham000 deleted the fix/current-challenge-id branch September 14, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 fix/improvement Some minor chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Setting Initial Active Challenge IDs
2 participants