-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Current Challenge ID to be null #235
Conversation
Why? Since it's still doing a redirect, why not keep it redirecting to the first challenge? I think we would see huge dropoff if we sent the add to |
Because the previous redirect occurred using the I think instead of hard-coding the redirect to go to the first challenge we should check where the ad actually links to and if we want to link to the first challenge we should just use that link. I don't really have any preference on where the ad links to. The first challenge is great because it's the fastest route to getting started, but linking to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but honestly I don't have a strong preference either way
OK, well my i'd favor not directing the user to the /home page yet.
I did change the ad to route to the first challenge directly.
/workspace
might redirect to to the first challenge for logged-out users and /dashboard
(which doesn't exist) for logged in users, or something along those lines.
I'm not against having a /home page, but I don't see the value in our current /home page from a user perspective.
All that being said, who knows maybe it would bump our sales. The ad won't be affected so do what you will.
I agree there's not a lot of meaningful functionality in the home route at the moment, but in my mind it was more like a placeholder for the dashboard in the future. We can definitely change the default redirects, just in refactoring the code here it became more simple to remove the default challenge logic altogether which resulted in this side effect related to the ad (but simpler code, I thought). Also, totally fine about keeping the first challenge - if I had to choose one for the ad redirect it would be the first challenge. |
This PR:
currentChallengeId
to benull
which happens to fix Bug Setting Initial Active Challenge IDs #234, and simplify some related code.Notes:
This removes the default fallback for the initial challenge as the first in the course, unless that
id
is specified in the URL which loads the app. I think our Google ad redirects to/workspace/
, which will now redirect to/home
instead. If that's the case, we could either:/home
is also a sensible starting place./workspace/iSF4BNIl
or/workspace/iSF4BNIl/hello-pairwise
.