Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new() method to Bit trait #141

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Conversation

jerry73204
Copy link
Contributor

This PR moves new() from B0 and B1 to Bit trait.
It lets the methods with Bit on return type generics to complete by calling Bit::new().

Copy link
Owner

@paholg paholg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, except that removing the old impls is technically a breaking change (the trait might not be in scope).

Since there's no harm in having both, would you mind re-adding B0::new() and B1::new()?

@jerry73204
Copy link
Contributor Author

I add the new() back and add a test to ensure both of them work.

Base automatically changed from master to main March 12, 2021 03:55
@paholg
Copy link
Owner

paholg commented Mar 12, 2021

Sorry for the delay; thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants