Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-5547] feat: refactoring onboarding's logic #506

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

pierpaolodidato89
Copy link
Collaborator

@pierpaolodidato89 pierpaolodidato89 commented Sep 26, 2024

List of Changes

  • Refactored the entire sync process of onboarding avoding multiple calls to Proxy Registry API
  • Created a factory to instantiate different objects according to their origin
  • Created an interface to define a common behavior - validation and custom valdation - among different objects retrieved from registries

Motivation and Context

In order to avoid the execution of the same code during the sync process of onboarding, the flow has been changed centralizing the access to proxy registry. Therefore, introducing an interface to define the common behavior, the code has been simplified deleting the nested if conditions

How Has This Been Tested?

I have deployed the feature branch in DEV and tested different scenarios as reported into JIRA ticket.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

pierpaolo.didato@emeal.nttdata.com added 10 commits September 17, 2024 17:08
…into feature/SELC-5547

� Conflicts:
�	apps/onboarding-ms/src/main/java/it/pagopa/selfcare/onboarding/service/OnboardingServiceDefault.java
�	apps/onboarding-ms/src/test/java/it/pagopa/selfcare/onboarding/service/util/OnboardingUtilsTest.java
pierpaolo.didato@emeal.nttdata.com added 2 commits October 16, 2024 11:22
Copy link
Contributor

@manuraf manuraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could add some description and title about this PR

pierpaolo.didato@emeal.nttdata.com added 2 commits October 21, 2024 09:26
…into feature/SELC-5547

� Conflicts:
�	apps/onboarding-ms/src/main/java/it/pagopa/selfcare/onboarding/service/OnboardingServiceDefault.java
�	apps/onboarding-ms/src/main/java/it/pagopa/selfcare/onboarding/service/util/OnboardingUtils.java
�	apps/onboarding-ms/src/main/resources/application.properties
�	apps/onboarding-ms/src/test/java/it/pagopa/selfcare/onboarding/service/OnboardingServiceDefaultTest.java
�	apps/onboarding-ms/src/test/java/it/pagopa/selfcare/onboarding/service/util/OnboardingUtilsTest.java
Copy link
Contributor

@manuraf manuraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could add title and some description about this PR!

@pierpaolodidato89 pierpaolodidato89 changed the title Feature/selc 5547 [SELC-5547] feat: refactoring onboarding's logic Oct 21, 2024
@pierpaolodidato89 pierpaolodidato89 marked this pull request as ready for review October 21, 2024 07:57
@pierpaolodidato89 pierpaolodidato89 requested a review from a team as a code owner October 21, 2024 07:57
Copy link

sonarcloud bot commented Oct 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants