Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-5400] fix: Added check on getUserFromPdv for check manager API #440

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

pierpaolodidato89
Copy link
Collaborator

List of Changes

  • Added condition to check if user exists in PDV for api check-manager. If not, the method returns false

Motivation and Context

In order to not get a 5xx error code, in case the user sent into request does not exist, the API will return false

How Has This Been Tested?

I have run ms locally and tested the api for every scenario

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pierpaolodidato89 pierpaolodidato89 marked this pull request as ready for review August 22, 2024 09:58
@pierpaolodidato89 pierpaolodidato89 requested a review from a team as a code owner August 22, 2024 09:58
Copy link

sonarcloud bot commented Aug 22, 2024

@andrea-putzu andrea-putzu merged commit 8b4cd3a into releases/0.3.3 Aug 22, 2024
11 checks passed
@andrea-putzu andrea-putzu deleted the bugfix/SELC-5400 branch August 22, 2024 10:08
@pierpaolodidato89 pierpaolodidato89 restored the bugfix/SELC-5400 branch August 23, 2024 12:32
@pierpaolodidato89 pierpaolodidato89 deleted the bugfix/SELC-5400 branch August 23, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants