Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-3948] refactor: Workflow Executor and Onboarding state updates #110

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

manuraf
Copy link
Contributor

@manuraf manuraf commented Jan 24, 2024

List of Changes

  • Removal of the Dedicated Update Function: Removed the function previously dedicated to updating the onboarding status. This change simplifies the workflow by reducing the number of functions involved in the onboarding process.

  • Workflow Executor Updates: Modified the workflow executor so that it now returns the next state of the processed onboarding request. This enhancement streamlines the flow of state transitions within the onboarding process.

  • Orchestration Function Responsibility: Updated the orchestration function to take over the responsibility of updating the request's state. This shift centralizes the control of state transitions to a single function, improving the overall process management.

Motivation and Context

By removing the dedicated function for updating the onboarding status and shifting this responsibility to the orchestration function, we reduce complexity and enhance the maintainability of our codebase. Furthermore, having the workflow executor return the next state directly contributes to a more efficient and clearer state transition mechanism.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@manuraf manuraf requested a review from a team as a code owner January 24, 2024 13:22
@github-actions github-actions bot added the functions Changes are related to functions label Jan 24, 2024
Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@manuraf manuraf merged commit 41be6a4 into main Jan 24, 2024
5 checks passed
@manuraf manuraf deleted the feature/SELC-3948 branch January 24, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functions Changes are related to functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant