Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add end input character to query regex #43

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gquadrati
Copy link
Contributor

List of Changes

  • Add end input character to query regex
  • Update tests

Motivation and Context

Forgetting the regex final character $ results in incorrect queries.
E.g. /api/v1/messages/(message-id)/message-status is counted in queries with regex /api/v1/messages/[^/]

Update dependency

Remeber to update also the package version here https://github.com/pagopa/opex-dashboard-azure-action/blob/main/Dockerfile

How Has This Been Tested?

Unit test

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gquadrati gquadrati marked this pull request as ready for review May 19, 2023 13:49
@gquadrati gquadrati requested a review from a team as a code owner May 19, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants