Skip to content

[IOCOM-1952] substituted payment updater api with pagopa ecommerce api #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 21, 2025
Merged

[IOCOM-1952] substituted payment updater api with pagopa ecommerce api #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
0ef504d
substituted payment updater api with pagopa ecommerce api
acuiuli Nov 29, 2024
25b06c1
remove package-lock.json
Garma00 Dec 3, 2024
8b0c29a
fix: adjust openapi file to correctly generate types with pagopa codegen
Garma00 Dec 3, 2024
9858982
fixed tests
acuiuli Dec 20, 2024
7bb11d3
removed PU openapi and client generation
acuiuli Dec 20, 2024
846e2e5
removed reference to PU
acuiuli Dec 20, 2024
e3ab16e
fixed yarn lock
acuiuli Dec 20, 2024
f8c1d72
removed PU client
acuiuli Dec 20, 2024
ba4fc67
doxker compose fix integration test
acuiuli Dec 20, 2024
5aba837
fixed testagent container name
acuiuli Dec 20, 2024
735db5d
fix yarn lock
acuiuli Jan 14, 2025
f66b93f
fixed yarn lock
acuiuli Jan 14, 2025
167e3f6
tests: update integration test env file
Garma00 Jan 16, 2025
de8458a
better error for testing
acuiuli Jan 16, 2025
047857e
small fixes
acuiuli Jan 16, 2025
113235c
fixed rptId generation for payment status
acuiuli Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devops/code-review-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,6 @@ stages:
cd __integrations__
yarn install --frozen-lockfile
sleep 30s
docker exec integrations___testagent_1 yarn test
docker exec fn_services_testagent yarn test
# ^^^ FIXME: reference container using a less arbitrary name
displayName: 'Execute tests'
91 changes: 48 additions & 43 deletions GetMessage/__tests__/handler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ import {
} from "../../__mocks__/mocks";

import { PaymentStatusEnum } from "../../generated/definitions/PaymentStatus";
import { FaultCodeCategoryEnum, PaymentDuplicatedStatusFaultPaymentProblemJson } from "../../generated/pagopa-ecommerce/PaymentDuplicatedStatusFaultPaymentProblemJson";
import { PaymentDuplicatedStatusFaultEnum } from "../../generated/pagopa-ecommerce/PaymentDuplicatedStatusFault";
import { PartyConfigurationFaultEnum } from "../../generated/pagopa-ecommerce/PartyConfigurationFault";
import { FaultCodeCategoryEnum as faultCode, PartyConfigurationFaultPaymentProblemJson } from "../../generated/pagopa-ecommerce/PartyConfigurationFaultPaymentProblemJson";

// Tests
// -----------------------
Expand Down Expand Up @@ -258,27 +262,16 @@ describe("GetMessageHandler", () => {
};
}

const getPaymentUpdaterClientMock = (paid: boolean = false) => ({
getMessagePayment: jest.fn().mockImplementation(() =>
TE.right({
status: 200,
value: {
paid
},
headers: {}
const getPagopaEcommerceClientMock = (status: number = 200, body?: PaymentDuplicatedStatusFaultPaymentProblemJson | PartyConfigurationFaultPaymentProblemJson) => ({
getPaymentRequestInfo: jest.fn().mockImplementation(() =>
TE.right(body ? {
value: body,
status: status
} : {
status: status
})()
)
});
const getBrokenPaymentUpdaterClientMock = (status: number) => ({
getMessagePayment: jest.fn().mockImplementation(() =>
TE.right({
status,
value: {
status
},
headers: {}
})()
)
),
getCarts: jest.fn()
});

it("should respond with a message if requesting user is the sender", async () => {
Expand All @@ -297,7 +290,7 @@ describe("GetMessageHandler", () => {
getNotificationStatusModelMock(),
{} as any,
mockMessageReadStatusAuth,
getPaymentUpdaterClientMock()
getPagopaEcommerceClientMock()
);

const result = await getMessageHandler(
Expand Down Expand Up @@ -337,7 +330,7 @@ describe("GetMessageHandler", () => {
getNotificationStatusModelMock(),
{} as any,
mockMessageReadStatusAuth,
getPaymentUpdaterClientMock()
getPagopaEcommerceClientMock()
);

const result = await getMessageHandler(
Expand Down Expand Up @@ -375,7 +368,7 @@ describe("GetMessageHandler", () => {
getNotificationStatusModelMock(),
{} as any,
mockMessageReadStatusAuth,
getPaymentUpdaterClientMock()
getPagopaEcommerceClientMock()
);

const result = await getMessageHandler(
Expand Down Expand Up @@ -419,7 +412,7 @@ describe("GetMessageHandler", () => {
{} as any,
{} as any,
mockMessageReadStatusAuth,
getPaymentUpdaterClientMock()
getPagopaEcommerceClientMock()
);

const result = await getMessageHandler(
Expand Down Expand Up @@ -464,7 +457,7 @@ describe("GetMessageHandler", () => {
{} as any,
{} as any,
mockMessageReadStatusAuth,
getPaymentUpdaterClientMock()
getPagopaEcommerceClientMock()
);

const result = await getMessageHandler(
Expand Down Expand Up @@ -507,7 +500,7 @@ describe("GetMessageHandler", () => {
{} as any,
{} as any,
mockMessageReadStatusAuth,
getPaymentUpdaterClientMock()
getPagopaEcommerceClientMock()
);

const result = await getMessageHandler(
Expand Down Expand Up @@ -547,7 +540,7 @@ describe("GetMessageHandler", () => {
{} as any,
{} as any,
mockMessageReadStatusAuth,
getPaymentUpdaterClientMock()
getPagopaEcommerceClientMock()
);

const result = await getMessageHandler(
Expand Down Expand Up @@ -586,7 +579,7 @@ describe("GetMessageHandler", () => {
getNotificationStatusModelMock(),
{} as any,
mockMessageReadStatusAuth,
getPaymentUpdaterClientMock()
getPagopaEcommerceClientMock()
);

const result = await getMessageHandler(
Expand Down Expand Up @@ -631,7 +624,7 @@ describe("GetMessageHandler", () => {
{} as any,
{} as any,
mockMessageReadStatusAuth,
getPaymentUpdaterClientMock()
getPagopaEcommerceClientMock()
);

const result = await getMessageHandler(
Expand Down Expand Up @@ -681,7 +674,7 @@ describe("GetMessageHandler", () => {
getNotificationStatusModelMock(),
{} as any,
mockMessageReadStatusAuth,
getPaymentUpdaterClientMock()
getPagopaEcommerceClientMock()
);

const result = await getMessageHandler(
Expand Down Expand Up @@ -729,7 +722,7 @@ describe("GetMessageHandler", () => {
getNotificationStatusModelMock(),
{} as any,
mockMessageReadStatusAuth,
getPaymentUpdaterClientMock()
getPagopaEcommerceClientMock()
);

const result = await getMessageHandler(
Expand Down Expand Up @@ -767,7 +760,7 @@ describe("GetMessageHandler", () => {
getNotificationStatusModelMock(),
{} as any,
mockMessageReadStatusAuth,
getPaymentUpdaterClientMock()
getPagopaEcommerceClientMock()
);

const result = await getMessageHandler(
Expand Down Expand Up @@ -850,7 +843,7 @@ describe("GetMessageHandler", () => {
getNotificationStatusModelMock(),
{} as any,
mockMessageReadStatusAuth,
getPaymentUpdaterClientMock()
getPagopaEcommerceClientMock()
);

const result = await getMessageHandler(
Expand Down Expand Up @@ -893,7 +886,7 @@ describe("GetMessageHandler", () => {
getNotificationStatusModelMock(),
{} as any,
mockMessageReadStatusAuth,
getPaymentUpdaterClientMock()
getPagopaEcommerceClientMock()
);

const result = await getMessageHandler(
Expand Down Expand Up @@ -943,7 +936,7 @@ describe("GetMessageHandler", () => {
getNotificationStatusModelMock(),
{} as any,
mockMessageReadStatusAuth,
getPaymentUpdaterClientMock()
getPagopaEcommerceClientMock()
);

const result = await getMessageHandler(
Expand Down Expand Up @@ -994,7 +987,7 @@ describe("GetMessageHandler", () => {
getNotificationStatusModelMock(),
{} as any,
mockMessageReadStatusAuth,
getPaymentUpdaterClientMock()
getPagopaEcommerceClientMock()
);

const result = await getMessageHandler(
Expand Down Expand Up @@ -1048,7 +1041,7 @@ describe("GetMessageHandler", () => {
getNotificationStatusModelMock(),
{} as any,
mockMessageReadStatusAuth,
getPaymentUpdaterClientMock()
getPagopaEcommerceClientMock()
);

const result = await getMessageHandler(
Expand Down Expand Up @@ -1100,7 +1093,11 @@ describe("GetMessageHandler", () => {
getNotificationStatusModelMock(),
{} as any,
mockMessageReadStatusAuth,
getPaymentUpdaterClientMock(true)
getPagopaEcommerceClientMock(409,
{
faultCodeCategory: FaultCodeCategoryEnum.PAYMENT_DUPLICATED,
faultCodeDetail: PaymentDuplicatedStatusFaultEnum.PAA_PAGAMENTO_DUPLICATO
})
);

const result = await getMessageHandler(
Expand Down Expand Up @@ -1152,7 +1149,11 @@ describe("GetMessageHandler", () => {
getNotificationStatusModelMock(),
{} as any,
mockMessageReadStatusAuth,
getPaymentUpdaterClientMock(true)
getPagopaEcommerceClientMock(409,
{
faultCodeCategory: FaultCodeCategoryEnum.PAYMENT_DUPLICATED,
faultCodeDetail: PaymentDuplicatedStatusFaultEnum.PAA_PAGAMENTO_DUPLICATO
})
);

const result = await getMessageHandler(
Expand Down Expand Up @@ -1204,7 +1205,7 @@ describe("GetMessageHandler", () => {
getNotificationStatusModelMock(),
{} as any,
mockMessageReadStatusAuth,
getBrokenPaymentUpdaterClientMock(404)
getPagopaEcommerceClientMock(404)
);

const result = await getMessageHandler(
Expand Down Expand Up @@ -1256,7 +1257,13 @@ describe("GetMessageHandler", () => {
getNotificationStatusModelMock(),
{} as any,
mockMessageReadStatusAuth,
getBrokenPaymentUpdaterClientMock(503)
getPagopaEcommerceClientMock(503,
{
faultCodeCategory: faultCode.DOMAIN_UNKNOWN,
faultCodeDetail: PartyConfigurationFaultEnum.PAA_ID_DOMINIO_ERRATO,
title: "UnexpectedError"
}
)
);

const result = await getMessageHandler(
Expand All @@ -1277,8 +1284,6 @@ describe("GetMessageHandler", () => {

expect(result).toEqual(
expect.objectContaining({
detail:
"Internal server error: Error retrieving Payment Status: Failed to fetch payment status from Payment Updater: 503",
kind: "IResponseErrorInternal"
})
);
Expand Down
Loading
Loading